Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1408 support array column type in recordedit #2340

Merged
merged 79 commits into from
May 6, 2024

Conversation

ladukaraniket
Copy link
Contributor

Implemented array input fields

image

@ladukaraniket ladukaraniket requested review from RFSH and jrchudy July 18, 2023 23:19
@ladukaraniket ladukaraniket self-assigned this Jul 18, 2023
@ladukaraniket ladukaraniket linked an issue Jul 18, 2023 that may be closed by this pull request
jrchudy

This comment was marked as resolved.

jrchudy

This comment was marked as resolved.

@RFSH RFSH mentioned this pull request Feb 1, 2024
src/assets/scss/_input-switch.scss Outdated Show resolved Hide resolved
src/assets/scss/_recordedit.scss Outdated Show resolved Hide resolved
src/components/input-switch/array-field.tsx Outdated Show resolved Hide resolved
src/components/input-switch/array-field.tsx Outdated Show resolved Hide resolved
src/components/input-switch/array-field.tsx Outdated Show resolved Hide resolved
src/components/input-switch/array-field.tsx Outdated Show resolved Hide resolved
RFSH

This comment was marked as resolved.

Copy link
Member

@RFSH RFSH left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the recent changes. It works now and the array inputs are aligned properly inside the "select all/some" panel. It seems like you missed the empty input case. The code is still sending [] when you leave the inputs empty.

I pulled latest master and resolved the conflicts. This change updates a lot of different dependencies, so make sure to do make deps-test before deploying/testing.

The last time I didn't pay too much attention to your tests, but now looking at it, I can't imagine that they would pass for you. The selectors that you used seem invalid to me. You're also directly using selectors. Please spend more time on testing. And this time around make sure they are passing and everything is ready.

src/components/input-switch/input-field.tsx Show resolved Hide resolved
src/components/input-switch/input-field.tsx Outdated Show resolved Hide resolved
src/components/input-switch/array-field.tsx Outdated Show resolved Hide resolved
src/assets/scss/_array-field.scss Outdated Show resolved Hide resolved
display: flex;
flex-direction: row;
gap: 5px;
[class*='input-switch-container'] {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is this rule trying to do?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It ensures that the input field takes all the available width. This is how it looks with and without this rule.
image
image

ladukaraniket and others added 13 commits April 24, 2024 16:30
- refactored the array-field comp a bit to avoid eslint max length warning
- fix a bug in date-time-field that was avoiding submit
- fix test cases
we were blindly passing output of register to InputSwitch which
caused the "forward ref" issue. so intead of forwarding ref on
InputSwitch, I just changed the array-field implementation to not pass
the reference as we don't need it and not using it.
@RFSH RFSH merged commit 16c657d into master May 6, 2024
1 check passed
@RFSH RFSH deleted the 1408-support-array-column-type-in-recordedit branch May 23, 2024 00:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support array column type in recordedit
3 participants